Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referenco to Znode in warning on dumpprivkey command #1350

Closed
nrsimha opened this issue Nov 12, 2023 · 1 comment · Fixed by #1458
Closed

Referenco to Znode in warning on dumpprivkey command #1350

nrsimha opened this issue Nov 12, 2023 · 1 comment · Fixed by #1458

Comments

@nrsimha
Copy link

nrsimha commented Nov 12, 2023

Describe the issue

When running dumpprivkey ADDRESS in Firo QT console warning text includes: "...it is not needed for Znode setup or diagnosis"

As Znodes are called just Masternodes, it should be instead:
"...it is not needed for Masternode setup or diagnosis" or "...it is not needed for Firo Masternode setup or diagnosis"

Local setup

MacOS, Firo Core version v0.14.12.1-gc7e3ef0e6 (64-bit)

@justanwar
Copy link
Member

We wanted to do it fully which includes both cosmetic (such as this) and the underlying parts such as znodeblsprivkey in firo.conf and the evoznode commands, but would have meant slowing down other major features such as Spark.

Re: #959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants