Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DID.Oldstyle #572

Open
matheus23 opened this issue Jan 19, 2022 · 0 comments
Open

Remove DID.Oldstyle #572

matheus23 opened this issue Jan 19, 2022 · 0 comments

Comments

@matheus23
Copy link
Member

@expede and I have talked about the *.DID.Oldstyle.Types module recently.
We were agreeing that we should just delete that code

I now saw that we're actually using it in production right now: We set the DNS TXT record for the server's DID to the Oldstyle Ed25519 DID.
That's not really a problem for our clients, because they're just signing the very last UCAN off for the server in any format, they don't care.
The server understands both formats. So I think we can "just" turn off the Oldstyle DID?

The only case I can think of where this would fail would be if our server would actually use it's DID to sign things, but I don't think that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant