Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] amazon_ads__portfolio_report should be downstream int_amazon_ads__portfolio_history #7

Open
2 of 4 tasks
fivetran-catfritz opened this issue Jul 20, 2023 · 0 comments

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Jul 20, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

int_amazon_ads__portfolio_history was created to generate an empty table if the source portfolio_history table is disabled. It is brought into most end models, example here and here, however it is not brought into amazon_ads__portfolio_report itself.

To keep amazon_ads__portfolio_report consistent and reduce confusion with the other models, suggest to update it to reference the int model. This would also benefit the lineage graph in the docs.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz changed the title [Feature] Portfolios int model [Feature] amazon_ads__portfolio_report should be downstream int_amazon_ads__portfolio_history Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant