-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify wayland has no themed cursor #239
Comments
I get the impression that simply flicking the Wayland socket on doesn't actually make it run with Wayland. I tried this myself as it's one of the last remaining XWayland apps. But after setting the override and relaunching the app I still see it in the output of Did you do something else to make this work by any chance? |
At least with the current verison, it does not support wayland AFAICT. |
Actually it does work, but you need to manually pass in the Electron wayland flags. This is a sample desktop file for doing that (
|
Ah neat. Testing it locally it shows corrupted rendering and then crashes though. Once its broadly usable we should add detecting wayland to our launcher scripts. |
That's strange. Seems to work fine for me on sway. |
Why not add it now, but not enable it by default? Apparenty it works for some people, and it can be a simple override to allow it. |
@etrnal70: where are your themes located? They should be in the appropriate XDG directories, not in directories like ~/.icons. Flatpak won't work with the legacy directories. |
@orowith2os Patch welcome. See Discord package for example. It even has a workaround for this bug. |
Indeed it does. I've submitted something upstream to Flatpak a while back, I think before this issue ever showed up. flatpak/flatpak#5375 |
I believe they are placed in the default |
It got fixed in latest update ! Closing this then EDIT: Nah no it's on xwayland. It's doesn't even use wayland now (even with flags) |
You can run spotify on wayland with I recommend using the same method Discord Flatpak uses, which works fine, which tweaked for Spotify (since it's not Electron, but an older CEF) would look like: FLAGS='--enable-gpu-rasterization --enable-zero-copy --enable-gpu-compositing --enable-native-gpu-memory-buffers --enable-oop-rasterization --enable-features=UseSkiaRenderer '
WAYLAND_SOCKET=${WAYLAND_DISPLAY:-"wayland-0"}
if [[ -e "$XDG_RUNTIME_DIR/${WAYLAND_SOCKET}" ]]
then
FLAGS="$FLAGS --ozone-platform=wayland"
fi
if [[ $XDG_SESSION_TYPE == "wayland" ]] && [ -c /dev/nvidia0 ]
then
FLAGS="$FLAGS --disable-gpu-sandbox"
fi |
I noticed the unthemed cursor behavior too with most chromium-based apps running under Wayland (notably also Discord). The fix for me was to add |
They're not exactly X-only, they were just grandfathered in; they're still valid variables on Wayland, and I don't think there's any other alternative to em. They work fine, no reason to not use em. Keeping in mind this only applies to some X variables, like XCURSOR_PATH. |
I managed to launch spotify on wayland. Is there any way to remove the default chromium titlebar? |
Maybe |
WaylandWindowDecorations seems to do nothing, otherwise Spotify in Wayland mode is a much better experience for me, as games can't grab the input from Spotify in the background. |
when I launched the spotify with wayland using these settings on plasma6 (using Nvidia GPU) it seems to get rid of the horrible xwayland flickering issue thats on nvidia, and it runs much smoother in general would be nice if this could be added, or at least be opt-in as discord has only minor issue is I notice is that now you will see the generic Wayland icons, not sure if its app bug or what my spec:
|
Please open a PR doing the same. |
When running with all of this, my cursor is in the wrong place. It's the correct size and theme, but the hovers and clicks register in different places from where my cursor is. In some cases, it's a couple of inches (15 inch screen) to the bottom right of the cursor, but in others places it's 4-5 inches away. I do get some errors when running on the command line:
|
It's nice to see spotify finally supports wayland ootb (just toggling wayland socket from flatseal). One thing that i notice is that using wayland will reset the cursor to the default, black one.
This isn't an issue when using xwayland
The text was updated successfully, but these errors were encountered: