Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake script should not be overriding configuration #103

Open
csingh opened this issue Dec 4, 2020 · 1 comment
Open

Rake script should not be overriding configuration #103

csingh opened this issue Dec 4, 2020 · 1 comment

Comments

@csingh
Copy link
Collaborator

csingh commented Dec 4, 2020

This line in the deimos:start task overrides the config.producers.backend value.

https://github.com/flipp-oss/deimos/blob/master/lib/tasks/deimos.rake#L10

I think this is bad practice because someone would be expecting to set all their configs in their deimos initializer file, but then when they try to run the app, this rake script would disable async kafka and cause some potential headaches and confusion. :P

Note though, that changing this would break backwards compatibility.

@dorner
Copy link
Member

dorner commented Dec 4, 2020

This might be a good opportunity to change the default backend to kafka from kafka_async since it's much easier to deal with issues and errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants