Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observation loading performance issue #76

Open
zhouji2013 opened this issue Oct 3, 2020 · 3 comments
Open

observation loading performance issue #76

zhouji2013 opened this issue Oct 3, 2020 · 3 comments
Assignees

Comments

@zhouji2013
Copy link
Member

There is an obvious delay between the loading of two submissions. Specifically, the gap between the executions of the last line of method write of ObservationDataWriter and the first line of method mapFieldSet of ObservationDataFieldSetMapper can be very long. In the current case of 689 submissions, the gap is smaller at the beginning, but for later submissions, say, at 500th submission, this gap becomes longer than 10 seconds. I should investigate what is happening during the gap. It could be a chance to improve the loading performance.

@zhouji2013 zhouji2013 self-assigned this Oct 3, 2020
@zhouji2013
Copy link
Member Author

With the latest data, the last gap is as long as about 18 seconds. Nothing is apparently supposed to happen during that gap.

@zhouji2013
Copy link
Member Author

zhouji2013 commented Oct 7, 2020

It looks like that all the gaps are caused by Spring Batch code instead of the application's own code.

  1. After I commented out all the content of ObservationDataFieldSetMapper.mapFieldSet() and ObservationDataWriter.write(), the duration and pattern of the gaps stayed the same.
  2. When observing with VisualVM, all the CPU usages are from org.springframework.batch.core.job.flow.JobFlowExecutor.executeStep (), which includes about half by org.springframework.batch.core.job.SimpleStepHandler.handleStep () and the other half by org.springframework.batch.core.job.flow.JobFlowExecutor.isStepRestart ().

@zhouji2013
Copy link
Member Author

Maybe we could not do much with this, but the reason that this got my attention is that this step used to take about 15 minutes for 122 submissions, but now it takes 90 minutes for 689 submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant