Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should not need to export LD_LIBRARY_PATH explicitly #161

Open
tpatki opened this issue Jul 3, 2024 · 2 comments
Open

Users should not need to export LD_LIBRARY_PATH explicitly #161

tpatki opened this issue Jul 3, 2024 · 2 comments

Comments

@tpatki
Copy link
Member

tpatki commented Jul 3, 2024

We need to check the CMake RPATH settings, as users are having to export LD_LIBRARY_PATH explicitly after installing. Most likely, this can be fixed by setting CMAKE_BUILD_WITH_INSTALL_RPATH to TRUE here. Needs to be tested.

set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)

@alizalisan
Copy link
Collaborator

@tpatki

I tested this and ran into the following error at make:

error: unable to load plugin '../weaver/weave/libWeavePass.so': 'libperfflow_parser.so: cannot open shared object file: No such file or directory'

@tpatki
Copy link
Member Author

tpatki commented Jul 10, 2024

@alizalisan I can reproduce, trying to find a fix. We can also decide to not fix this, as we do support setting up through PERFFLOWASPECT_DIR (as shown in examples).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants