Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/production/kustomization.yaml: namespace left out by intention? #102

Open
johanneskastl opened this issue Sep 22, 2023 · 1 comment

Comments

@johanneskastl
Copy link

There is no namespace in the production file, while it exists in the staging one?

https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/production/kustomization.yaml#L3

vs.

https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/staging/kustomization.yaml#L3

@kingdonb
Copy link
Member

kingdonb commented Oct 2, 2023

I think we've had this conversation elsewhere, reminds me of a thread in Slack.

I don't think this is an error, the production resources already have the production namespace in them, in this case it's podinfo since the app being deployed to production is podinfo, and production might have many apps in it.

https://github.com/fluxcd/flux2-kustomize-helm-example/blob/main/apps/base/podinfo/kustomization.yaml

The namespace directive is used in the ../base/podinfo kustomization overlay, and it's overrided in the staging so that staging can live on the same cluster as production. (If there were multiple apps, then staging would need to find a different method.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants