From 49ccd36339385fad0353217cfc63d97f680b52e4 Mon Sep 17 00:00:00 2001 From: DenChenn Date: Wed, 23 Oct 2024 19:23:50 +0800 Subject: [PATCH] refactor: lint Signed-off-by: DenChenn --- .../pkg/apis/flyteworkflow/v1alpha1/gate_test.go | 6 ++++-- .../pkg/apis/flyteworkflow/v1alpha1/identifier_test.go | 6 ++++-- .../pkg/apis/flyteworkflow/v1alpha1/register_test.go | 3 ++- .../apis/flyteworkflow/v1alpha1/subworkflow_test.go | 10 ++++++---- 4 files changed, 16 insertions(+), 9 deletions(-) diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/gate_test.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/gate_test.go index 92f6b639e1..2fc532d4e4 100644 --- a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/gate_test.go +++ b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/gate_test.go @@ -2,12 +2,14 @@ package v1alpha1 import ( "bytes" - "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" + "testing" + "github.com/golang/protobuf/jsonpb" "github.com/golang/protobuf/proto" "github.com/stretchr/testify/assert" "google.golang.org/protobuf/types/known/durationpb" - "testing" + + "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" ) func mockMarshalPbToBytes(msg proto.Message) ([]byte, error) { diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/identifier_test.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/identifier_test.go index 4d26ffe94a..1267aec09b 100644 --- a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/identifier_test.go +++ b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/identifier_test.go @@ -1,9 +1,11 @@ package v1alpha1 import ( - "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" - "github.com/stretchr/testify/assert" "testing" + + "github.com/stretchr/testify/assert" + + "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" ) func TestIdentifierJSONMarshalling(t *testing.T) { diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/register_test.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/register_test.go index 18286ecf0e..f55a596ad8 100644 --- a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/register_test.go +++ b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/register_test.go @@ -1,9 +1,10 @@ package v1alpha1 import ( + "testing" + "github.com/stretchr/testify/assert" "k8s.io/apimachinery/pkg/runtime" - "testing" ) func TestKind(t *testing.T) { diff --git a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/subworkflow_test.go b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/subworkflow_test.go index fa9d39512f..c0534ef9ea 100644 --- a/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/subworkflow_test.go +++ b/flytepropeller/pkg/apis/flyteworkflow/v1alpha1/subworkflow_test.go @@ -1,9 +1,11 @@ package v1alpha1 import ( - "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" - "github.com/stretchr/testify/assert" "testing" + + "github.com/stretchr/testify/assert" + + "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" ) func TestWorkflowNodeSpec_GetLaunchPlanRefID(t *testing.T) { @@ -22,9 +24,9 @@ func TestWorkflowNodeSpec_GetLaunchPlanRefID(t *testing.T) { } func TestWorkflowNodeSpec_GetSubWorkflowRef(t *testing.T) { - workflowId := "TestWorkflowID" + workflowID := "TestWorkflowID" wfNodeSpec := &WorkflowNodeSpec{ - SubWorkflowReference: &workflowId, + SubWorkflowReference: &workflowID, } nilWfNodeSpec := &WorkflowNodeSpec{}