From a91d585dcdfbff713d13ece370396082089dafbc Mon Sep 17 00:00:00 2001 From: Yukesh Kumar Date: Tue, 9 Aug 2022 10:49:20 +0530 Subject: [PATCH] fixes update message when the version is same (#322) Signed-off-by: Yukesh Kumar --- pkg/github/githubutil.go | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/pkg/github/githubutil.go b/pkg/github/githubutil.go index 142bc5ca..486e7584 100644 --- a/pkg/github/githubutil.go +++ b/pkg/github/githubutil.go @@ -169,22 +169,23 @@ func GetUpgradeMessage(latest string, goos platformutil.Platform) (string, error return "", err } - var message string - if isGreater { - message = fmt.Sprintf(commonMessage, stdlibversion.Version, latest) - symlink, err := CheckBrewInstall(goos) - if err != nil { - return "", err - } - if len(symlink) > 0 { - message += brewMessage - } else if goos == platformutil.Darwin { - message += darwinMessage - } else if goos == platformutil.Linux { - message += linuxMessage - } - message += fmt.Sprintf(releaseURL, latest) + if !isGreater { + return "", err + } + message := fmt.Sprintf(commonMessage, stdlibversion.Version, latest) + + symlink, err := CheckBrewInstall(goos) + if err != nil { + return "", err + } + if len(symlink) > 0 { + message += brewMessage + } else if goos == platformutil.Darwin { + message += darwinMessage + } else if goos == platformutil.Linux { + message += linuxMessage } + message += fmt.Sprintf(releaseURL, latest) return message, nil }