Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Template Updated #502

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

neeraj3029
Copy link
Member

Fixes #498

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Pull Request now asks for Screenshots and is more descriptive now.

Changes proposed in this pull request:

Pull Request now asks for Screenshots and is more descriptive now.

@@ -4,6 +4,7 @@
<!-- Add the issue number that is fixed by this PR (In the form Fixes #123) -->

Fixes #
[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as already at line 4 description about it is given. You can edit that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both lines have different meanings, please see carefully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I am saying that please edit at line 4 to merge both information. As both are related to issue number.

Copy link
Member

@championpaddler championpaddler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeraj3029 Squash Your Commits/

Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits

@neeraj3029
Copy link
Member Author

@samagragupta Please review

@samagragupta
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request template needs changes
4 participants