Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing instrumentation to orchestrator clients #226

Open
pscoro opened this issue Oct 10, 2024 · 1 comment · May be fixed by #231
Open

Add tracing instrumentation to orchestrator clients #226

pscoro opened this issue Oct 10, 2024 · 1 comment · May be fixed by #231
Assignees
Labels
enhancement New feature or request

Comments

@pscoro
Copy link
Collaborator

pscoro commented Oct 10, 2024

Description

We want to add more tracing instrumentation to the orchestrator to enrich the telemetry thats collected. In particular, this issue tracks the instrumentation of the orchestrator clients. This should also include propagation of the traceparent header to and possibly from the client services and the user.

Acceptance Criteria

  • Instrumentation on all handlers and other expensive/significant functions
  • Descriptive logging for important blocks of code
  • Metrics for client requests are taken
  • traceparent propagation
    • Propagate traceparent header to outgoing client requests
    • Check for traceparent header on incoming responses from clients else use the traceparent prepared for the request

The traceparent should not be propagated back in the response of the orchestrator

@pscoro
Copy link
Collaborator Author

pscoro commented Oct 17, 2024

Addressed by #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants