Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing in onDrop prop causes handleDrop to be bypassed #46

Open
juchiu opened this issue Nov 3, 2017 · 3 comments · May be fixed by #52
Open

Passing in onDrop prop causes handleDrop to be bypassed #46

juchiu opened this issue Nov 3, 2017 · 3 comments · May be fixed by #52

Comments

@juchiu
Copy link

juchiu commented Nov 3, 2017 •
edited
Loading

The rest operator on dropzoneProps overrides the onDrop prop.

react-dropzone-s3-uploader/src/DropzoneS3Uploader.js

Line 195 in 3f55cac

<Dropzone ref={c => this._dropzone = c} onDrop={this.handleDrop} {...dropzoneProps}>

@traveled1
Copy link

I have the same issue. Any workaround? Thanks in advance!

alukach added a commit to alukach/react-dropzone-s3-uploader that referenced this issue Feb 5, 2018
@alukach
Prevent onDrop from being overridden
c1dce99 
Resolves founderlab#46
@alukach alukach linked a pull request Feb 5, 2018 that will close this issue
Open
ilyakatz pushed a commit to execonline-inc/react-dropzone-s3-uploader that referenced this issue Mar 15, 2018
@alukach @ilyakatz
Prevent onDrop from being overridden
007758c 
Resolves founderlab#46
@dancrumb
Copy link

dancrumb commented May 1, 2018

For the time being, you can add onDrop to the notDropzoneProps property.

This just burned me for a whole day, so it would be great to get this documented, at the very least

@dancrumb
Copy link

dancrumb commented May 1, 2018

see #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent onDrop from being overridden alukach/react-dropzone-s3-uploader
3 participants
@dancrumb @traveled1 @juchiu