Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conduit streaming interface to querying #22

Open
YoEight opened this issue Jul 4, 2018 · 2 comments
Open

Add a conduit streaming interface to querying #22

YoEight opened this issue Jul 4, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@YoEight
Copy link
Contributor

YoEight commented Jul 4, 2018

Greetings,

I use the stream function a lot, and while it does the job well for most use-cases, I find it too limiting from time to time. The best example I have is when I'm dealing with batching and have to handle the case when I have a batch smaller than the size I fixed earlier.

One significant quality of life improvement would be to know when we've reached the end of the iterator. It seems doable by looking at that line where we can know how many rows we got in the resultset prior.

What would be excellent is exposing a stream-processing-like interface using conduit library. I'm leaning towards the latter. That's a task I'm willing to tackle on, once I got more bandwidth at work.

What do you think about such improvements?

Thanks for your time.

@chrisdone
Copy link
Contributor

I'm open to adding a conduit for streaming a query. I considered adding one initially.

Provided you handle resources correctly and don't leak anything, including due exceptions, an additional streaming interface via conduit should be fine. 👍

@YoEight
Copy link
Contributor Author

YoEight commented Jul 4, 2018

I'll be happy to be at your scrutiny once I got some time for implementing this feature 😄

@chrisdone chrisdone changed the title Improving the stream interface. Add a conduit streaming interface to querying Jul 18, 2018
@chrisdone chrisdone added the enhancement New feature or request label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants