-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reason for disabling embedded relationships #4
Comments
Reason: I was lazy to add the test. Does it actually work? Do you think you could contribute a test? If not at some point I'll try myself |
Thanks Frank. Will try to add a test for it. |
We've got a PR for this - testing on our code base then we will submit. Adds tests and fixes code. |
@BryanCrotaz Thanks! Sorry I didn't have the chance to get around to this. |
PR #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Frank,
Was wondering if there was a reason for disabling embedded relationships?
https://github.com/frank06/ember-data-save-relationships/blob/master/addon/index.js#L42,L43
Some of my relationships needs that data in order to be saved on the server side. I tried to remove that line and the add-on seems to be working fine. Was wondering if I could safely do this?
The text was updated successfully, but these errors were encountered: