Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should not use deprecated Swig package #6

Open
fohlin opened this issue Nov 28, 2018 · 0 comments
Open

Examples should not use deprecated Swig package #6

fohlin opened this issue Nov 28, 2018 · 0 comments

Comments

@fohlin
Copy link

fohlin commented Nov 28, 2018

README.md has some nice introductory examples using Swing templates. However, paularmstrong/swig is unsupported and marked deprecated on npm. The corresponding docs link gives a 404.

I recommend switching to another template language for the examples here.


I have investigated using the community-supported node-swig/swig-templates which does work but with a poor experience in its current state. It's poor mainly because the docs are not updated and still reference the deprecated package (see node-swig/swig-templates#32). For reference, this works fine:

const swig = require('swig-templates');
const consolidate = require('@frctl/consolidate');

const swigAdapter = consolidate('swig', swig)
fractal.components.engine(swigAdapter);
fractal.components.set('ext', '.swig');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant