Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extensions should be a core dependency #298

Closed
observingClouds opened this issue Oct 10, 2024 · 2 comments
Closed

typing_extensions should be a core dependency #298

observingClouds opened this issue Oct 10, 2024 · 2 comments

Comments

@observingClouds
Copy link

Hi 👋 ,

Thank you for this great package! If I am not mistaken, the typing_extensions package should be a core dependency as it is used in core.py and loaded during module import.

Probably,

"typing_extensions; python_version<'3.11'",

should just move to the main dependencies.

Example of failing import:

 from upath import UPath
../../../.local/lib/python3.10/site-packages/upath/__init__.py:10: in <module>
    from upath.core import UPath
../../../.local/lib/python3.10/site-packages/upath/core.py:25: in <module>
    from typing_extensions import Self
E   ModuleNotFoundError: No module named 'typing_extensions'

( universal_pathlib-0.2.5)

@ap--
Copy link
Collaborator

ap-- commented Oct 10, 2024

@observingClouds

Thanks for reporting!

This issue has been fixed on current main, and will be included in the next release.

xref #290

@ap-- ap-- closed this as completed Oct 10, 2024
@observingClouds
Copy link
Author

Sorry I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants