Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MSVC branch #50

Open
projectitis opened this issue Apr 16, 2022 · 5 comments
Open

Updated MSVC branch #50

projectitis opened this issue Apr 16, 2022 · 5 comments

Comments

@projectitis
Copy link

projectitis commented Apr 16, 2022

Hi FTK. Any chance of an updated MSVC branch? :)
i.e. quickjspp.hpp to latest (and other files), and quickjs patches applied?
Relates to #23

@projectitis
Copy link
Author

projectitis commented Apr 17, 2022

I am working on this now.

  • Created new branch off sharedptr called sharedptr-msvc
  • Replaced quickjs subfolder with c-smile's latest code
  • Applied patches from quickjs/patches folder
  • Adding meson build definitions
  • Currently testing

@projectitis
Copy link
Author

projectitis commented Apr 17, 2022

@ftk could you create a new branch off sharedptr called sharedptr-msvc (or similar) and I'll create a PR for my branch to that. Is that ok?

p.s. My fork has this as the master now.

@ftk
Copy link
Owner

ftk commented Apr 17, 2022

Done. https://github.com/ftk/quickjspp/tree/sharedptr-msvc
BTW ci and sharedptr branches can be compiled with MSVC (cmake only since it works by downloading a DLL and linking against it)

@projectitis
Copy link
Author

projectitis commented Apr 17, 2022

Thanks :)

What is the difference between all the branches? The shared pointer branch has changes that Sam and I were asking about, but what about the ci branch?

Also, what flavor of QuickJS is the dll?

@ftk
Copy link
Owner

ftk commented Apr 19, 2022

ci branch only has MSVC-related changes. It's also merged in sharedptr branch but not master branch yet.
The dll is vanilla quickjs with quickjspp patches applied, it's however compiled by mingw-w64 since MSVC can't compile quickjs.
https://github.com/ftk/quickjspp/actions/runs/2176597938/workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants