Seperating presentation and code

[daniel-soli]

This goes back to my first PR which was humongous, but it had a nice feature; seperating presentation from code.
This is really a good idea, not just for seperating responsibilities, but also for viewability.

For me personally, have a codeblock within a razor page is just like having javascript directly in html pages.
I think this should be introduced, but this is not my decision to make. But i heavily suggest it.

Now.. discuss :)

[modersohn]

Thanks for bringing this up here, that's certainly something which needs discussion and - if we decide to do it - needs to be orchestrated so we end up having one PR which is exclusively just separating code and HTML without sneaking in any other changes.

... seperating presentation from code.
... seperating responsibilities

The generally agreed rule is to separate presentation logic from "business" logic.

But the code part of a .razor page/component is actually very much part of the presentation logic. AFAIK it cannot be run or even be tested separately. It is tightly coupled with the HTML part.

My point to keep it together is the easier navigation between code and HTML. But I admit that this advantage is vanishing, the larger the file becomes.

For example, would you actually want to split up something short like L1AccountLink.razor? If yes, I absolutely don't favour this. If no, then why have separate standards? That seems very subjective, split it up whenever you feel like it has become too big?

[daniel-soli]

You would have to do a reasing for each file. L1AccountLink would not be seperated. No need to.
But pages should at least be seperated in my opinion.

Code seperation is a basic rule of thumb in Most cases, but like that specific example with a minimal component helper it would not be desireable.

[modersohn]

This sound's very much like a subjective feeling that a file has become too large and therefore should be split up.

Putting the two parts in separate files doesn't actually make the code any less coupled.

The largest page we have is AccountDetails by far. But instead of just splitting HTML and code, I would much rather split it up into components (e.g. Balances, NFTs and Transactions). Because that would actually decouple things and would give us flexibility to change the sites page structure in the future.

[fudgebucket27]

I honestly like how everything is now and find it's easier to navigate. We could split up bigger pages into smaller components as suggested by modersohn.