fix: corrected theory for 9d #3829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the content for 9d theory as vite now has 3 typescript confguration files
|
I don't seem to be able to assign a reviewer so I am pinging. @mluukkai Please review my PR |
|
@EledenGreen @anttiharju Please review my PR |
EledenGreen
reviewed
Oct 21, 2024
There was a problem hiding this comment.
As i checked, vite react-ts template now contains 3 config files.
But the typed-notes was created a year ago and doesn't have the tsconfig.app.json file. So, probably have to update that as well.
|
I'm nowhere close to part 9 so can't help here. I've just been fixing what I've come across I assume mluukkai would eventually check this PR he seems fairly active |
|
@mluukkai Please review this PR, and suggest changes if required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the project with vite for react in typecript, now there are 3 configuration files which are tsconfig.app.json , tsconfig.json and tsconfig.node.json.
However, in the theory of 9d , it is wrongly written. In this PR, I have updated the its theory according to latest version of VIte
Fixes #3803