Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all DOM-related constructions to another package #2

Open
xgrommx opened this issue May 3, 2019 · 3 comments
Open

Move all DOM-related constructions to another package #2

xgrommx opened this issue May 3, 2019 · 3 comments

Comments

@xgrommx
Copy link

xgrommx commented May 3, 2019

Hello @paldepind
I think will be better to have another package for DOM-related constructions.
We should use FRP without DOM-related things.
That just my thoughts

@paldepind
Copy link
Member

Hi @xgrommx. Thank you for sharing your opinion.

We should use FRP without DOM-related things.

Yes, we definitely agree on that 👍 As a case in point, @limemloh has been working on using Hareactive and Turbine together with NativeScript where there is no DOM.

On the current master of purescript-hareactive all DOM related functions are isolated in the Hareactive.DOM module. Additionally, the latest release of Hareactive moved all DOM related features into a separate file which must be imported like import ... from "@funkia/hareactive/dom". This file is only imported in the PureScript bindings here i the DOM module.

All in all, this means that if one do not use the Hareactive.DOM module then zero DOM related code will be loaded.

Do you think this avoid the need for another package for DOM-related functions? Because, Hareactive has very few DOM related things and don't feel that moving them into a separate package is worth the complexity and extra overhead for the users. What do you think?

@xgrommx
Copy link
Author

xgrommx commented May 3, 2019

@paldepind I think another package will be better. For example if I working with nodejs and I don't want DOM-related things.

@paldepind
Copy link
Member

@xgrommx What do you think the practical benefits of a separate package is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants