How to add extra address line for Apt/Unit#?

[xjlin0]

Great package! Would it be possible to add one extra field of Address to enter extra info such as apartment/floor/unit info of the same street address? Or should we add extra info in the route field instead? Here is my PR, please let me know if it's ok to add one such field, thanks!
#142

class Address(models.Model):
    extra = models.CharField(max_length=20, blank=True)

Also , since ordering will be ('locality', 'route', 'street_number', 'extra'), probably it's better to add index to route/street_number/extra for the db performance.

[banagale]

Hello Jack, thank you for the praise and the PR.

I understand there could be use cases where having an apartment number/floor/unit specific field on the Address model would be useful.

However, I am reluctant to merge an arbitrary new extra field into the model at this stage to handle this.

The reason is the project is installed in many places and there is already a goal to handle a better, more abstract model architecture.

I will look again at this as I look at other more basic improvements but probably would not accept this field.

Instead, I would suggest you use the Django Address model, but subclass it and add your extra field. This will allow you to continue to take updates as they may come in.

I did see your search error fix for admin. I haven't validated this but I can merge that commit once I do.

[xjlin0]

Sure no problems! thanks again for the suggestion, Merry Christmas and Happy New Year!

[banagale]

Sure no problems! thanks again for the suggestion, Merry Christmas and Happy New Year!

You too.