From bdbc84fa2400fe7a8b4787ec77ef02c1c8bc785a Mon Sep 17 00:00:00 2001
From: Michael Wenzel <wenzel@uber.com>
Date: Sun, 21 Apr 2019 21:57:34 -0400
Subject: [PATCH] hardcode crossorigin script attribute

---
 plugins/ssr-plugin.js               |  4 ++--
 test/e2e/dynamic-import-app/test.js | 14 --------------
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/plugins/ssr-plugin.js b/plugins/ssr-plugin.js
index b08c2348..df5632f7 100644
--- a/plugins/ssr-plugin.js
+++ b/plugins/ssr-plugin.js
@@ -114,8 +114,8 @@ const SSRBodyTemplate = createPlugin/*:: <SSRBodyTemplateDepsType,SSRBodyTemplat
 
         for (let url of criticalChunkUrls) {
           const crossoriginAttr = url.startsWith(__webpack_public_path__)
-            ? ''
-            : ' crossorigin="anonymous"';
+            ? ' crossorigin="anonymous"'
+            : '';
           preloadHints.push(
             `<link rel="preload" href="${url}" nonce="${
               ctx.nonce
diff --git a/test/e2e/dynamic-import-app/test.js b/test/e2e/dynamic-import-app/test.js
index c33a3602..aaf90b25 100644
--- a/test/e2e/dynamic-import-app/test.js
+++ b/test/e2e/dynamic-import-app/test.js
@@ -175,13 +175,6 @@ test('`fusion build` app with dynamic imports integration', async () => {
     'one extra script after loading new route'
   );
 
-  t.ok(
-    await page.$$eval('script[src]:not([type="application/json"])', els =>
-      els.every(el => el.crossOrigin === null)
-    ),
-    'non-module scripts do not have crossorigin attribute'
-  );
-
   t.ok(
     await page.$$eval('script[src]:not([type="application/json"])', els =>
       // eslint-disable-next-line
@@ -274,13 +267,6 @@ test('`fusion build` app with Safari user agent and same-origin', async () => {
     'one extra script after loading new route'
   );
 
-  t.ok(
-    await page.$$eval('script[src]:not([type="application/json"])', els =>
-      els.every(el => el.crossOrigin === null)
-    ),
-    'non-module scripts do not have crossorigin attribute'
-  );
-
   t.ok(
     await page.$$eval('script[src]:not([type="application/json"])', els =>
       // eslint-disable-next-line