Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting functional interfaces #103

Merged
merged 1 commit into from
May 5, 2024

Conversation

bricka
Copy link
Contributor

@bricka bricka commented Oct 10, 2023

@github-actions github-actions bot added the grammar Related to the grammar label Oct 10, 2023
@VladimirMakaev
Copy link
Collaborator

@bricka Can you please rebase your fix and regenerate the parser?

@bricka
Copy link
Contributor Author

bricka commented Oct 25, 2023

@VladimirMakaev Rebased and regenerated :)

@bricka
Copy link
Contributor Author

bricka commented Oct 26, 2023

Hrm...I just tried redoing the tree-sitter generate, but my local one shows no changes to parser.c. Any ideas what could be causing the failed check?

@VladimirMakaev
Copy link
Collaborator

Can it be due to this #92?

@bricka
Copy link
Contributor Author

bricka commented Jan 16, 2024

I tried to re-generate inside the node:18 image, but that didn't seem to fix the problem for me :(

@bricka
Copy link
Contributor Author

bricka commented Apr 19, 2024

I think my last attempt was on my Mac laptop, but I've just made a change from my Linux laptop. Let's see if that makes the parser generation work correctly.

@VladimirMakaev VladimirMakaev merged commit 3c65915 into fwcd:main May 5, 2024
1 of 2 checks passed
@VladimirMakaev
Copy link
Collaborator

I'm going to revert this for now since it broke the build

VladimirMakaev added a commit that referenced this pull request May 5, 2024
VladimirMakaev added a commit that referenced this pull request May 5, 2024
@bricka
Copy link
Contributor Author

bricka commented May 24, 2024

@VladimirMakaev Hi Vladimir. Did it break because of the generated parser?

If so, how can we push this forward? Could someone who can generate the parser correctly check out this branch, generate the parser, and then push that?

@VladimirMakaev
Copy link
Collaborator

Not sure if you can see the job below, but seems like the generated parser issue

https://github.com/fwcd/tree-sitter-kotlin/actions/runs/8954309216/job/24593808540

I don't have any more context on this beyond #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grammar Related to the grammar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional interface parsing has ERROR
2 participants