Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit IUPAC tables #269

Open
ahwagner opened this issue Jan 31, 2021 · 1 comment
Open

Explicit IUPAC tables #269

ahwagner opened this issue Jan 31, 2021 · 1 comment
Assignees
Labels
Docs Stayin' Alive Issues to exempt from stale issue processing

Comments

@ahwagner
Copy link
Member

Currently, we link to the Wikipedia IUPAC tables, and previously the genome.jp IUPAC tables which have some slight differences (termination and gap codes). We should be explicit about what we accept and what it means.

Create IUPAC tables in spec, citing one of these sources. Update Sequence regex in schema accordingly.

@ahwagner ahwagner added the Stayin' Alive Issues to exempt from stale issue processing label Jan 31, 2021
@larrybabb
Copy link
Contributor

larrybabb commented Nov 20, 2023

We need to take the Regex expressions in our code and explicitly document them in our Residue section of the docs to support the consistent reference (whether that be the wikipedia link or the genome.jp link or both above).

Look at the recently updated biotuils version and make sure our vrs2.0 code and docs reference that. We should also keep these updated as we build new releases of VRS beyond 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Stayin' Alive Issues to exempt from stale issue processing
Projects
None yet
Development

No branches or pull requests

3 participants