Close log file

[pagorek18]

Hi,
I've created logger like this

std::vector<spdlog::sink_ptr> sinks;
sinks.push_back(std::make_shared<spdlog::sinks::stdout_color_sink_st>());
sinks.push_back(std::make_shared<spdlog::sinks::basic_file_sink_st>("filename"));
auto logger = std::make_shared<spdlog::logger>("logger", begin(sinks), end(sinks));
spdlog::register_logger(logger);

My build is failing with sonar inspection that opened file is never close. Does anyone can confirm that spdlog will close the file during the logger object destruction?

[tt4g]

file_helper destructor will close the file.

spdlog/include/spdlog/details/file_helper-inl.h

Lines 23 to 26 in 100f300

	SPDLOG_INLINE file_helper::~file_helper()
	{
	close();
	}

Should you call spdlog::shutdown() before application exit.
Because this function release all logger from spdlog global registry.