Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_find_tools misses changed tools if tool XML is unchanged #1129

Open
bernt-matthias opened this issue Jan 15, 2021 · 0 comments · May be fixed by #1130
Open

ci_find_tools misses changed tools if tool XML is unchanged #1129

bernt-matthias opened this issue Jan 15, 2021 · 0 comments · May be fixed by #1130

Comments

@bernt-matthias
Copy link
Contributor

ci_find_tools --changed_in_commit_range RANGE seems not find changed tools if the main xml file is not changed (e.g. if only scripts or test-data is changed).

Not sure if this is the desired behavior, but the finding such tools would be needed in the IUC PR workflow in the linting step: https://github.com/galaxyproject/tools-iuc/blob/4daa375d022673d2437d609b1865b78c64b04415/.github/workflows/pr.yaml#L156

I guess for each non-xml file one would need to traverse the tree up to the repo root and take the first tool xml that is found in one of these paths.

@nsoranzo nsoranzo changed the title ci_find_tools misses chnaged tools if tool xml is unchanged ci_find_tools misses changed tools if tool XML is unchanged Jan 16, 2021
@bernt-matthias bernt-matthias linked a pull request Jan 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant