Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Private Package Registries in Project testing #271

Closed
nvandessel opened this issue May 31, 2024 · 0 comments · Fixed by #272
Closed

Support Private Package Registries in Project testing #271

nvandessel opened this issue May 31, 2024 · 0 comments · Fixed by #272

Comments

@nvandessel
Copy link
Contributor

nvandessel commented May 31, 2024

Context

With recent feature add to support private registries when testing packages, I believe we should also extend this support to testing projects as well. This should be a simple feature add with the scaffolding in place and working for packages.

Suggested solution

I believe all we would need to do is move the place where the .upmconfig.toml is made, to outside of the scope of the package exclusive logic in ubuntu/run_tests.sh. Since we're testing a project, it should be expected that the scoped registry settings would already be setup, so we would not need to worry about updating the manifest.json like we do with packages.

Considered alternatives

I believe my suggested solution is simple and low risk enough that I haven't put any major thought into alternatives.
Alternatively a user could do this into another step in their CI workflow, but considering we already have the logic in place I see it as a QOL upgrade to using this action.

Additional details

The effort is extremely low here, so I'm going to implement this feature, and I'll open a PR and link it to this issue once done.

As of now, package testing is only supported on Linux runners, per this issue: #224
I believe that's largely due to the use of jq, so we could introduce support for private registries on more platforms than just Linux. I was planning on just focusing on the one platform, but I could look into others as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant