Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomReadinessCheck for Helm Deployer not working #600

Open
enrico-kaack-comp opened this issue Sep 21, 2022 · 1 comment
Open

CustomReadinessCheck for Helm Deployer not working #600

enrico-kaack-comp opened this issue Sep 21, 2022 · 1 comment
Labels
area/helm-deployer Helm Deployer kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority) status/accepted Issue was accepted as something we need to work on

Comments

@enrico-kaack-comp
Copy link
Contributor

How to categorize this issue?

/area helm-deployer
/kind bug
/priority 3

What happened:
Using a custom readiness check with the real helm deployers does not work. It always succeed.

How to reproduce it (as minimally and precisely as possible):
use a simple helm chart and add a readiness check. Set ProviderConfiguration.HelmDeployment to true.

Anything else we need to know?:
The Custom ReadinessCheck seems to report success in this early exit:
https://github.com/gardener/landscaper/blob/master/pkg/deployer/lib/readinesscheck/customreadinesscheck.go#L44

len(c.ManagedResources) == 0 is true, it seems the ManagedResources are not correctly tracked by the real helm deployer.

Environment:

  • Landscaper version: v0.35.0-dev
  • Kubernetes version (use kubectl version): v1.24.3
  • Others:
@gardener-robot gardener-robot added area/helm-deployer Helm Deployer priority/3 Priority (lower number equals higher priority) labels Sep 21, 2022
@enrico-kaack-comp enrico-kaack-comp mentioned this issue Sep 30, 2022
Merged
@enrico-kaack-comp enrico-kaack-comp mentioned this issue Oct 11, 2022
Merged
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 31, 2023
@achimweigel
Copy link
Contributor

@enrico-kaack-comp could this issue be closed?

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 18, 2023
@achimweigel achimweigel reopened this Aug 18, 2023
@gardener-robot gardener-robot added status/accepted Issue was accepted as something we need to work on and removed status/closed Issue is closed (either delivered or triaged) labels Aug 18, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm-deployer Helm Deployer kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority) status/accepted Issue was accepted as something we need to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achimweigel @gardener-robot @enrico-kaack-comp