Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the import of pull requests? Our fork supports some functionality #70

Open
jaylenw opened this issue Apr 11, 2022 · 5 comments
Open

Comments

@jaylenw
Copy link

jaylenw commented Apr 11, 2022

Hello, is there any interests to support the importation of Pull Requests? We are aware there are some "gotchas" when trying to import PRs with GitHub's API as certain edge cases are not supported. However, we have modified our fork of the code to support some cases of importing PRs. We have added documentation to our fork in the README.md file. If there is interest, please checkout our fork with the code that supports importing PRs here and if all is well let us know to open a PR to this repository. We are willing to make small changes to our fork so that a PR can be approved and merged into this repository but we can not spend much more time on our fork.

Thanks!

Branch with our changes: https://github.com/CityOfLosAngeles/github-csv-tools/tree/import-pull-requests
Diff with our changes as of now: master...CityOfLosAngeles:import-pull-requests.

@jaylenw jaylenw changed the title Support the import of pull request? Our fork supports some functionality Support the import of pull requests? Our fork supports some functionality Apr 11, 2022
@gavinr
Copy link
Owner

gavinr commented Apr 11, 2022

Thanks a lot for the post. I really appreciate you posting the proposed code update. I'd like to leave this open to see if others chime in with the need for this feature.

@jaylenw
Copy link
Author

jaylenw commented Apr 12, 2022

Hello @gavinr , no problem, your welcome. Thanks for your work on this tool!

@94rain
Copy link

94rain commented Oct 18, 2022

Thanks for the proposed code changes! I'd love to see this feature as well.

I just tried it with etcd.io/etcd (via githubCsvTools -p --exportAttributes=number,title,labels,state,assignees,milestone,comments,created_at,updated_at,closed_at), and it works well!

@DavidGriffith
Copy link

Not to necro-post, but I want to see this as well.

@jaylenw
Copy link
Author

jaylenw commented Dec 5, 2023

Hello @gavinr any updated decision on us opening a pull request to support the proposed functionality? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants