localstack/minio cleanup #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 18, 2023 13:33
qqmyers
reviewed
Dec 20, 2023
| @@ -0,0 +1,3 @@ | |||
| [default] | |||
There was a problem hiding this comment.
Random Q: Would it help to use a non-default profile? (The store has to specify which profile in that case.)
There was a problem hiding this comment.
@qqmyers these are broken out by service account, and really only for testing, so I think I'll leave them as-is for now? can always add in profiles later, unless you think I'm making a mistake by not including them now?
There was a problem hiding this comment.
It's fine - not hard to add later
pdurbin
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker composebinary instead of Ansible module for compatibility with RHEL9Closes #338