Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move common build code to sails-builder #157

Closed
wants to merge 5 commits into from
Closed

feat: Move common build code to sails-builder #157

wants to merge 5 commits into from

Conversation

holykol
Copy link
Contributor

@holykol holykol commented Apr 18, 2024

Resolves #95

DennisInSky
DennisInSky reviewed May 3, 2024
View reviewed changes
Copy link
Member

@DennisInSky DennisInSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving this into draft for the time being as the final structure of crates and build flow is unclear yet

@holykol holykol marked this pull request as draft May 3, 2024 16:24
@holykol holykol marked this pull request as ready for review May 13, 2024 13:04
@holykol holykol requested a review from DennisInSky May 14, 2024 11:37
@holykol holykol marked this pull request as draft May 14, 2024 11:55
@DennisInSky
Copy link
Member

Outdated

@DennisInSky DennisInSky deleted the holykol/sails-builder branch July 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf Awaiting requested review from NikVolf

@DennisInSky DennisInSky Awaiting requested review from DennisInSky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pack building commands into simple crate
2 participants
@holykol @DennisInSky