Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks and tweaks #3

Open
laerm0 opened this issue Apr 7, 2020 · 13 comments
Open

checks and tweaks #3

laerm0 opened this issue Apr 7, 2020 · 13 comments

Comments

@laerm0
Copy link
Contributor

laerm0 commented Apr 7, 2020

Hey there –

I am now digging in to help you bring this along. I'm wondering about your build process. The designspace appears to be irrelevant. How did you do it? A build script and/or documentation would be helpful.

I'm also fine-toothed-combing the glyphs file. So far I have only found a few very minor things, namely the name table (no pun intended :) ). I've forked and I'll PR later on.

@laerm0
Copy link
Contributor Author

laerm0 commented Apr 8, 2020

Oh, since you said you'd be working on this today 😁 , thoughts on this one?

@yosiasz
Copy link
Contributor

yosiasz commented Apr 8, 2020

I used one of the google tools and python tools out there to do a lot of the export and generation of files. This speaks to the fact that the barrier to entry is super tough for new scripts. No simple documentation that spells out what to do. Lots of trial and errors from different documentations. I need to create my own documentation, maybe it will also help other brand new entries. Uncharted waters here Micah! 😁

@laerm0
Copy link
Contributor Author

laerm0 commented Apr 8, 2020

The two docs with the best guidelines for Google Fonts are the CONTRIBUTING.md doc and then the project checklist gives further details.

One of the main focuses now is to have a consistent, repeatable build process. There's one-size-fits-all for most fonts, but yours will have to be special because you wrote your OpenType code by hand (nothing wrong with that). I'm going to take care of a bunch of the stuff that needs to be fixed for that process to work.

You can do it. 👍

@yosiasz
Copy link
Contributor

yosiasz commented Apr 10, 2020

Ok whats next sir? What do you need from me

@laerm0
Copy link
Contributor Author

laerm0 commented Apr 13, 2020

Well, for starters I'll send a PR with the stuff I've updated. Please merge it back in so we're on the same page. I'm still trying to get a repeatable build script going. Some OT issues now (not in your code, just getting build tools to recognize it).

One thing you could do in the meantime: the README needs more details. Description, history of your design and process, etc. 1000 characters or so is the goal.

@davelab6
Copy link

@m4rc1e had put together a new 2020 checklist at https://github.com/googlefonts/gf-docs/tree/master/Spec :)

I agree that the process to add a new script is opaque, I'll see about fixing that

@laerm0
Copy link
Contributor Author

laerm0 commented Apr 29, 2020

Hey @yosiasz , how's it coming? Need any help?

@yosiasz
Copy link
Contributor

yosiasz commented Apr 29, 2020

Hello @laerm0. Totally swamped at work. Probably will be a long while before I can take a look at this. So sorry.

@laerm0
Copy link
Contributor Author

laerm0 commented Apr 29, 2020

Cool, no problem. Do you want me to forge ahead on anything? The OT issue in #8 is the only blocker I have.

@yosiasz
Copy link
Contributor

yosiasz commented May 2, 2020

@laerm0 please forge ahead. I will try to look at #8 maybe tonight.

@laerm0
Copy link
Contributor Author

laerm0 commented May 4, 2020

Sounds good @yosiasz . I'll get back to it and just throw in a little dummy text that allows that part of the OT code to compile.

@yosiasz
Copy link
Contributor

yosiasz commented May 8, 2020

The more I look the more it seems geez/ethiopic resources are rare to find in one consolidated location. So I created the following

https://github.com/geeztypes/geezresources

@yosiasz
Copy link
Contributor

yosiasz commented May 11, 2021

@laerm0 back in the saddle. I have roped in my sister to create more fonts. hopefully coming soon. please let me know next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants