Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Healtcheck endpoint with different metrics #99

Open
4TT1L4 opened this issue Feb 28, 2024 · 0 comments
Open

[FEATURE] Healtcheck endpoint with different metrics #99

4TT1L4 opened this issue Feb 28, 2024 · 0 comments
Labels
Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Medium High-Level effort estimation. Category "medium effort". Task A feature request or general task involving code changes.

Comments

@4TT1L4
Copy link
Contributor

4TT1L4 commented Feb 28, 2024

Is your feature request related to a problem? Please describe.
At the moment it is not easy to monitor the performance of the smart order router. The monitoring of the SOR instance is only possible by monitoring the logs and matching regular expressions to extract some information about the inner working.

Describe the solution you'd like
It would be great to have a healthcheck endpoint, that would return different operational metrics.

The SOR would open a port and listen on it for HTTP requests. When a GET request arrives, it would response with a JSON document like the following document:

{
  "started": "2024-02-12 17:01",
  "last-scan": "2024-02-18 14:01",
  "scan-count": 15543,
  "match-count": 154,
  "tx-submitted": 5
}

The JSON structure above is just a proposal. Improvements and changes are welcome.

Describe alternatives you've considered
Alternatives could be to add some prometheus or some other monitoring tool compatible interface

Additional context
The monitoring and observability of the SOR must be improved. This proposal suggest to improve this aspect of the SOR.

@4TT1L4 4TT1L4 added Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Medium High-Level effort estimation. Category "medium effort". Task A feature request or general task involving code changes. labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Medium High-Level effort estimation. Category "medium effort". Task A feature request or general task involving code changes.
Projects
None yet
Development

No branches or pull requests

1 participant