Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site specific configurations #5

Open
pbiology opened this issue Apr 9, 2021 · 2 comments
Open

Site specific configurations #5

pbiology opened this issue Apr 9, 2021 · 2 comments

Comments

@pbiology
Copy link

pbiology commented Apr 9, 2021

How are we dealing with site specific configs? Should each site just keep their own configs outside of the repo, or should we have them in conf/gothenburg.config for instance?

I see a pro where new sites then have some material where they can copy others and use as a template. Also it's nice to have stuff in the same place as well.

Downsides I guess is that there will be a bunch of stuff not relevant for the pipeline.

@sylvinite
Copy link
Member

There are two considerations:

  • This repo is public. That means the site must be comfortable sharing their configs including file paths
  • Every time a site wants to change their on site configuration, they have to modify genomic-medicine-sweden /
    gms-artic

I think the best course of action is to have a basic configuration here, and then a site specific override (if necessary) stored locally on site.

@pbiology
Copy link
Author

OK. But then perhaps a structure for such a configuration file, and then site-specific config files stored outside the repo. I'm running a branch now to set up such a system so when done I can do a pull-request for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants