Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow filter options based on other filters #37

Closed
brianlove opened this issue Aug 4, 2023 · 1 comment · Fixed by #48
Closed

Narrow filter options based on other filters #37

brianlove opened this issue Aug 4, 2023 · 1 comment · Fixed by #48
Assignees
@brianlove
Milestone
PARAT v2

Comments

@brianlove
Copy link
Contributor

From #35 (review):

  1. If I apply a filter (e.g., Country = China) and then apply the group, the country filter is still applied, so the table looks blank.

As filters (and groups) get applied, restrict the filter options available to other columns to only cover those actually available based on the other filter selections (for example: if Group X is selected, but Group X doesn't include any Chinese companies, then don't list China in the country dropdown)
@brianlove brianlove self-assigned this Aug 4, 2023
@brianlove brianlove mentioned this issue Aug 4, 2023
Merged
@brianlove brianlove added this to the PARAT v2 milestone Aug 4, 2023
brianlove added a commit that referenced this issue Aug 16, 2023
@brianlove
Narrow filter options to only those still applicable
f4d40c6 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
@brianlove brianlove mentioned this issue Aug 16, 2023
Merged
@brianlove brianlove linked a pull request Aug 21, 2023 that will close this issue
Narrow filter options to only those still applicable given the applied filters #48
Merged
brianlove added a commit that referenced this issue Aug 21, 2023
@brianlove
Narrow filter options to only those still applicable
4b290c6 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
jmelot pushed a commit that referenced this issue Aug 22, 2023
@brianlove @jmelot
Narrow filter options to only those still applicable
e4d65d5 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
jmelot pushed a commit that referenced this issue Aug 22, 2023
@brianlove @jmelot
Narrow filter options to only those still applicable
5e1f575 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
jmelot pushed a commit that referenced this issue Aug 22, 2023
@brianlove @jmelot
Narrow filter options to only those still applicable
2b30b57 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
brianlove added a commit that referenced this issue Aug 22, 2023
@brianlove
Narrow filter options to only those still applicable
2f12168 
Limit the filter options present in dropdowns to only those that are
still possible given the currently-applied filters from other columns.

Closes #37
@brianlove
Copy link
Contributor Author

Closed by #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianlove brianlove

Labels
None yet
Projects
None yet
Milestone
PARAT v2
Development

Successfully merging a pull request may close this issue.

Narrow filter options to only those still applicable given the applied filters georgetown-cset/parat
1 participant
@brianlove