Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Customization for Highlight Styles in Feature Selection #10536

Open
1 task done
congchen1101 opened this issue Sep 9, 2024 · 4 comments · May be fixed by #10537
Open
1 task done

Enhanced Customization for Highlight Styles in Feature Selection #10536

congchen1101 opened this issue Sep 9, 2024 · 4 comments · May be fixed by #10537

Comments

@congchen1101
Copy link
Contributor

congchen1101 commented Sep 9, 2024

Description

This enhancement introduces the ability to customize highlight styles for features selected through clicking on the map or via the featureEditor. Users can now define highlight styles such as color, line thickness, and opacity in the localConfig.json, enabling more visually distinctive and contextually relevant feature highlighting.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Tasks

No tasks being tracked yet.
@tdipisa
Copy link
Member

tdipisa commented Sep 9, 2024

Dear @congchen1101. Thank you for using MS. Is this coming from an opened discussion in mailing list? Is this something you have in plan to contribute for?

congchen1101 added a commit to congchen1101/MapStore2 that referenced this issue Sep 9, 2024
Enhanced Customization for Highlight Styles in Feature Selection
- Enabled defining `highlightStyle` objects under `Map` and `Identify` sections in localConfig.json to allow customization of highlight styles.
- Updated and added relevant tests to reflect these changes.

On behalf of DB Systel GmbH
@congchen1101
Copy link
Contributor Author

Hello @tdipisa,

Yes, this is something I am planning to contribute.

Best regards,
Cong Chen

@tdipisa
Copy link
Member

tdipisa commented Sep 9, 2024

Hello @tdipisa,

Yes, this is something I am planning to contribute.

Best regards, Cong Chen

Hi @congchen1101 interesting. Thank you. Anyway, the issue you have opened is quite generic and it is not so clear what you would like to achieve with this at the UI/UX level. I'm wondering if you have already discussed that on the mailing list, that's something I suggest you to do if your purpose is to contribute to the MS core. The goal in staying in touch with the MS's ML is to provide your proposal and find a proper agreement for it with the dev core team members. Thank you so much again for using and developing with MapStore.

@tdipisa tdipisa linked a pull request Sep 9, 2024 that will close this issue
12 tasks
@congchen1101
Copy link
Contributor Author

Hi @tdipisa,

Thank you for your feedback and suggestion. I apologize if my initial issue description was too generic. To clarify, my goal with this enhancement is to allow developers to define custom highlight styles for selected features, specifically focusing on properties like color and line thickness. This would provide more flexibility and control over the map’s visual representation.

It’s important to note that this change will not alter the current default highlight styles; if users do not make any additional definitions, the existing highlight behavior will remain unchanged.

I will take your advice and start a discussion on the mailing list to provide a more detailed proposal and gather feedback from the core dev team members.

Thank you again for your guidance. I look forward to collaborating further to make this contribution beneficial to the MapStore community.

Best regards,
Cong Chen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants