You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trailers will only be emitted if chunked encoding is used for the response; if it is not (e.g. if the request was HTTP/1.0), they will be silently discarded.
the Trailer header is not being explicitly added to the response
"chunked encoding" is not being explicitly used for the response (maybe chunked is enabled by default?)
Are the trailers written in normal use? How do they affects e.g. interactive CSV download in a browser?
If the trailers are not written, or a failure is not communicated clearly to users, there might be alternative/additional ways to communicate an error to a user. These might include:
.csv: e.g. write a final line --- ERROR DOWNLOADING CSV DATA ---
.zip: e.g. deliberately corrupt the file
The text was updated successfully, but these errors were encountered:
When there is an error in a streamed response, an HTTP trailer is added at:
central-backend/lib/http/endpoint.js
Lines 191 to 195 in 7c75951
From node docs:
There is a unit test covering the error handler:
central-backend/test/unit/http/endpoint.js
Line 503 in 7c75951
It's unclear if the trailers are actually written in practice:
response.addTrailers()
was calledTrailer
header is not being explicitly added to the responseAre the trailers written in normal use? How do they affects e.g. interactive CSV download in a browser?
If the trailers are not written, or a failure is not communicated clearly to users, there might be alternative/additional ways to communicate an error to a user. These might include:
.csv
: e.g. write a final line--- ERROR DOWNLOADING CSV DATA ---
.zip
: e.g. deliberately corrupt the fileThe text was updated successfully, but these errors were encountered: