This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
add typings to the module #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I appreciate the effort that went into this, we're intentionally avoiding having TypeScript typings in raven-node. They're a burden to maintain, people get upset if they don't work, they will be continuously out of date, and there hasn't been enough community push for them. We only support them in raven-js because Angular 2 is an officially supported platform, and it uses TypeScript by default. We'd prefer if you consider submitting these to DefinitelyTyped instead. |
|
Would love this as well |
|
This would be super useful. Pushing this to DefinitelyTyped just adds a layer of complexity and doesn't help at all with compatibility issues, imo. |
|
typings for raven-node landed here DefinitelyTyped/DefinitelyTyped#15429 |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #189
borrows heavily from #189 (comment)