Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goroutine support in logrus implementation #513

Open
Deofex opened this issue Dec 7, 2022 · 1 comment · May be fixed by #936
Open

Add goroutine support in logrus implementation #513

Deofex opened this issue Dec 7, 2022 · 1 comment · May be fixed by #936
Assignees

Comments

@Deofex
Copy link

Deofex commented Dec 7, 2022

Summary

The logrus implementation always use the same Sentry hub. Logrus loggers are often shared between goroutines. Your documentation states that using separate hubs for each goroutine is mandatory.

Motivation

With the current logrus implementation a new logger is mandatory for each goroutine. It would be nice if the implementation would be able to integrate with a single logger, while still being able to use the logger in different goroutines.

@cleptric
Copy link
Member

cleptric commented Dec 7, 2022

That makes a lot of sense, I put it into our backlog.
In the meantime, PRs are always welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants