Notice error escalate to exception

[tommysitehost]

Hi all, I have a weird issue. I have added PHP Sentry SDK to my project, and it is working great. Transactions, errors are showing up in our own OSS Sentry instance.

However, I noticed that any warning or notice PHP errors are now getting caught by our exception handler after initialising Sentry (the handler didn't catch these error before we added Sentry). Not sure where to look here, any ideas? Does Sentry SDK mangle set_error_handler?

My application is running PHP 7.4 and SDK version is 4.8.0.

sentry/sentry: [debug] The "Sentry\Integration\ExceptionListenerIntegration, Sentry\Integration\ErrorListenerIntegration, Sentry\Integration\FatalErrorListenerIntegration, Sentry\Integration\RequestIntegration, Sentry\Integration\TransactionIntegration, Sentry\Integration\FrameContextifierIntegration, Sentry\Integration\EnvironmentIntegration, Sentry\Integration\ModulesIntegration" integration(s) have been installed.

Here is an example of the error:

ErrorException: Notice: Undefined index:

[stayallive]

This is our error handler:

sentry-php/src/ErrorHandler.php

Lines 317 to 355 in 1ea8e3d

	private function handleError(int $level, string $message, string $file, int $line, ?array $errcontext = []): bool
	{
	$isSilencedError = error_reporting() === 0;
	if (\PHP_MAJOR_VERSION >= 8) {
	// Starting from PHP8, when a silenced error occurs the `error_reporting()`
	// function will return a bitmask of fatal errors that are unsilenceable.
	// If by subtracting from this value those errors the result is 0, we can
	// conclude that the error was silenced.
	$isSilencedError = 0 === (error_reporting() & ~self::PHP8_UNSILENCEABLE_FATAL_ERRORS);
	// However, starting from PHP8 some fatal errors are unsilenceable,
	// so we have to check for them to avoid reporting any of them as
	// silenced instead
	if ($level === (self::PHP8_UNSILENCEABLE_FATAL_ERRORS & $level)) {
	$isSilencedError = false;
	}
	}
	if ($this->shouldHandleError($level, $isSilencedError)) {
	if ($isSilencedError) {
	$errorAsException = new SilencedErrorException(self::ERROR_LEVELS_DESCRIPTION[$level] . ': ' . $message, 0, $level, $file, $line);
	} else {
	$errorAsException = new \ErrorException(self::ERROR_LEVELS_DESCRIPTION[$level] . ': ' . $message, 0, $level, $file, $line);
	}
	$backtrace = $this->cleanBacktraceFromErrorHandlerFrames($errorAsException->getTrace(), $errorAsException->getFile(), $errorAsException->getLine());
	$this->exceptionReflection->setValue($errorAsException, $backtrace);
	$this->invokeListeners($this->errorListeners, $errorAsException);
	}
	if ($this->previousErrorHandler !== null) {
	return false !== ($this->previousErrorHandler)($level, $message, $file, $line, $errcontext);
	}
	return false;
	}

We do convert errors to an exception to allow us to capture them. However I don't believe we leak the exception outside our own error handling and Sentry specific integration listeners. Maybe you notice something in there we mixed up?

[tommysitehost]

Hi @stayallive, thanks for your response.

We do set our own set_error_handler:

		set_error_handler(array('handlers'), E_ERROR);

Interestingly, if I run this function before initialising sentry, it escalates the notice error. If I run this function after initialising Sentry, it doesn't send any notice errors anymore. If I don't run it all together, everything seems to be working as it should.