Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating IP Reallocate Fails When Using Pool ID #325

Open
EricHorton opened this issue Apr 3, 2017 · 0 comments
Open

Floating IP Reallocate Fails When Using Pool ID #325

EricHorton opened this issue Apr 3, 2017 · 0 comments
Labels

Comments

@EricHorton
Copy link

vagrant: v1.9.1
vagrant-openstack-provider: v0.9.0

When configuring os.floating_ip_pool, vagrant-openstack-provder correctly allocates a new floating ip if it is provided with the pool's id. However, even with os.floating_ip_pool_always_allocate = false, it does not correctly reuse floating ips that have already been allocated but are not attached to an instance.

I believe the issue is with search_free_ip, which appears to be using string.include? to check if the ip name matches the pool id. This works correctly if the pool name is used instead.

Because of the way include? is used, it may also be possible to construct a case where an incorrect ip is used if two pools have similar names. For instance, if the correct pool name is a substring of the other, although I have not tried this.

@ggiamarchi ggiamarchi added the bug label May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants