Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Promised response from onMessage..." error #707

Closed
ghost opened this issue May 18, 2021 · 9 comments · Fixed by #966 or ghostery/adblocker#2980
Closed

"Promised response from onMessage..." error #707

ghost opened this issue May 18, 2021 · 9 comments · Fixed by #966 or ghostery/adblocker#2980
Assignees
Labels
Bug Something isn't working Firefox

Comments

@ghost
Copy link

ghost commented May 18, 2021

Description

Weird error Promised response from onMessage listener went out of scope appears.

Expected Behavior

Everything goes fine.

Actual Behavior

Ghostery throws an error Error: Promised response from onMessage listener went out of scope on all pages.

Steps to Reproduce

  1. Go to https://ghostery.com
  2. Open console
  3. See weird errors coming from Ghostery.

Versions

  • Browser: Firefox 88.0.1
  • OS: Linux Xubuntu 20.04
  • Node: 14.15.5
  • NPM: 7.10.0
@badmansan
Copy link

Confirm this bug.

Error: Promised response from onMessage listener went out of scope ... background.js:841:170

Versions

  • Browser: Firefox 88-89
  • OS: Windows 7
  • Ghostery 8.5.5

Any ideas?

@christophertino
Copy link
Contributor

This sometimes occurs when the Tracker Tally (aka Purple Box) is removed from the page while trackers are still loading. Try disabling it under Settings > Tracker Tally.

@ghost
Copy link
Author

ghost commented Jul 27, 2021

This sometimes occurs when the Tracker Tally (aka Purple Box) is removed from the page while trackers are still loading. Try disabling it under Settings > Tracker Tally.

Ok, will test! I removed Ghostery as it was slow...

@michi-s
Copy link

michi-s commented Jul 1, 2022

This sometimes occurs when the Tracker Tally (aka Purple Box) is removed from the page while trackers are still loading. Try disabling it under Settings > Tracker Tally.

I have the same issue.

The Tracker-Tally is already disabled.

@philipp-classen
Copy link
Member

philipp-classen commented Aug 18, 2022

Potentially related to the other problem reported for Chrome recently; in its core, the warning on Chrome is about promises that are neither being resolved nor rejected. Probably, it is the same in Firefox.

I found the Firefox issues harder to reproduce though: while the Chrome issue almost instantly triggers, it is more work to get it on Firefox. That worked for me:

  • Go to https://www.spiegel.de/
  • Wait for around three minutes

Now I got multiple of these warnings:

 Error: Promised response from onMessage listener went out of scope

Probably also one of the main sources of this discussion:
https://stackoverflow.com/questions/69506506/what-does-error-promised-response-from-onmessage-listener-went-out-of-scope-m

Most likely, it is also the communication of the adblocker engine (between the extension background and the content script). I would not expect that it leads to a concrete bug, as promises are only kept unresolved when there is no need for an action to be taken by the content script. Still, would be good to fix it, so we don't spam the error logs.

@philipp-classen
Copy link
Member

If someone knows a quick way to reproduce the error message, please share. That would help us a lot, since always waiting 3 minutes make it tedious to debug it, unfortunately.

@ghost
Copy link
Author

ghost commented Dec 16, 2022

This only took 1.5 years to be fixed

@sghostt
Copy link

sghostt commented Dec 16, 2022

Hey @Sly-Little-Fox, send an email to [email protected] with the link to this GitHub issue so we can show our thanks for your report and feedback with a coupon code to try our Ghostery Contributor Status features. Thanks for using Ghostery :)

@ghost
Copy link
Author

ghost commented Dec 16, 2022

Hey @Sly-Little-Fox, send an email to [email protected] with the link to this GitHub issue so we can show our thanks for your report and feedback with a coupon code to try our Ghostery Contributor Status features. Thanks for using Ghostery :)

I no longer use Ghostery, so...

remusao pushed a commit to ghostery/adblocker that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Firefox
Projects
None yet
6 participants