Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicted commit getting checked out into working directory #5247

Open
Afsoon opened this issue Oct 21, 2024 · 5 comments
Open

Conflicted commit getting checked out into working directory #5247

Afsoon opened this issue Oct 21, 2024 · 5 comments
Labels
bug Something isn't working feedback requested Feedback was requested to help resolve the issue performance Application is too slow rust Pull requests that update Rust code

Comments

@Afsoon
Copy link

Afsoon commented Oct 21, 2024

Version

Version 0.13.3 (20241021.130557)

Operating System

macOS

Distribution Method

dmg (Apple Silicon)

Describe the issue

Unable to see the changes after apply a branch or If I create a branch.

Some screenshots:
Create a branch
image

Apply a branch
image

How to reproduce

Just create a new branch or apply a old branch

Expected behavior

To be able to see my branches.

Relevant log output

2024-10-21T15:42:09.616568Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: close time.busy=7.29µs time.idle=18.6µs id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0 fs_events=2 fs_events=2 ignored=0 ignored=0 git_noop=1 git_noop=1 git=0 git=0 project=0 project=0
2024-10-21T15:42:11.648221Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: new id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0
2024-10-21T15:42:11.648249Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: close time.busy=15.9µs time.idle=12.5µs id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0 fs_events=37 fs_events=37 ignored=0 ignored=0 git_noop=15 git_noop=15 git=0 git=0 project=0 project=0
2024-10-21T15:42:12.663974Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: new id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0
2024-10-21T15:42:12.663994Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: close time.busy=7.58µs time.idle=13.5µs id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0 fs_events=2 fs_events=2 ignored=0 ignored=0 git_noop=1 git_noop=1 git=0 git=0 project=0 project=0
2024-10-21T15:42:14.699724Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: new id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0
2024-10-21T15:42:14.699762Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: close time.busy=25.6µs time.idle=13.3µs id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0 fs_events=55 fs_events=55 ignored=0 ignored=0 git_noop=22 git_noop=22 git=0 git=0 project=0 project=0
2024-10-21T15:42:16.990116Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: new id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0
2024-10-21T15:42:16.990284Z  INFO set_project_active:set_project_to_window:file monitor:handle debounced events: crates/gitbutler-watcher/src/file_monitor.rs:119: close time.busy=47.8µs time.idle=122µs id=0f86b13c-a1e6-401a-90ca-66b492b645a0 window="main" project_id=0f86b13c-a1e6-401a-90ca-66b492b645a0 fs_events=133 fs_events=133 ignored=0 ignored=0 git_noop=11 git_noop=11 git=0 git=0 project=0 project=0
@Afsoon Afsoon added the bug Something isn't working label Oct 21, 2024
@Afsoon
Copy link
Author

Afsoon commented Oct 21, 2024

NVM, I'm closing because I found the error. I don't know how I manage to create a virtual branch so big with so many conflicts after update gitbutler.

image image

It's failing because it can't render it.

@Afsoon Afsoon closed this as completed Oct 21, 2024
@Byron Byron added the performance Application is too slow label Oct 21, 2024
@Byron
Copy link
Collaborator

Byron commented Oct 21, 2024

Thanks for reporting!

I think it would be good to re-open this issue as the image I see there shows a 'virtual tree', checked out into the worktree, which should never happen. Maybe I am wrong about this, and @Caleb-T-Owens would definitely know better.

Also, the performance issues is something we are working on, there are a couple of known ones that still need to be sorted out, but this one here seems like a bug to me that may have caused a performance issue to surface.

@Caleb-T-Owens
Copy link
Contributor

This indeed should never ever happen.

@Afsoon would you be able to send in your log files or describe/provide a reproduction for this issue, because it would be really good to get to the bottom of this.

You can find your log files with this guide: https://docs.gitbutler.com/development/debugging
And you can email them to: [email protected]

Sorry for the inconvenience.

@Caleb-T-Owens Caleb-T-Owens reopened this Oct 21, 2024
@Caleb-T-Owens Caleb-T-Owens changed the title Unable to create or apply virtual branches Conflicted commit getting checked out into working directory Oct 21, 2024
@Caleb-T-Owens Caleb-T-Owens added rust Pull requests that update Rust code feedback requested Feedback was requested to help resolve the issue labels Oct 21, 2024
@Afsoon
Copy link
Author

Afsoon commented Oct 22, 2024

@Caleb-T-Owens I'm sending right now the logs. I don't know how to reproduce it exactly, but I can give you more information:

  • My project state before update Gitbutler was:
    • 2 virtual branches, the default branch had commited changes, one of the commits was a merge from main.
    • The second virtual branch had files pending to be commited and only one commit, that was the merge from main, same as the other branch

After update to the latest version:

  • Like 80% of my was removed from the root directory, and copy the same removed content to the folders .conflict-base-0, .conficlit-side-0 and .conflict-side-1
  • A README was created with the content You have checked out a GitButler Conflicted commit. You probably didn't mean to do this., but the app never warned me.

Sorry for the inconvenience.

Don't worry! The software is pre 1.0 and I know what I'm into it.

@Afsoon
Copy link
Author

Afsoon commented Oct 22, 2024

I don't now if it can help you, but I had to do a git prune, because git was complaining too many unreachable loose objects.

Stats before the git prune, using git count-objects -v:

count: 34494
size: 248224
in-pack: 20718
packs: 50
size-pack: 11132
prune-packable: 0
garbage: 0
size-garbage: 0

After prune it:

count: 29921
size: 226872
in-pack: 20718
packs: 50
size-pack: 11132
prune-packable: 0
garbage: 0
size-garbage: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback requested Feedback was requested to help resolve the issue performance Application is too slow rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

3 participants