Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query predicates aren't validated #388

Open
BekaValentine opened this issue Feb 1, 2024 · 2 comments
Open

Query predicates aren't validated #388

BekaValentine opened this issue Feb 1, 2024 · 2 comments

Comments

@BekaValentine
Copy link
Contributor

In the JS library, we accidentally had predicates #eq and #not-eq, which are incorrect (they should be #eq? and #not-eq?), but which caused no error during execution. They simply failed silently.

This is obviously a problem with tree-sitter, but also it would be good if we had some kind of query validation as well, since we clearly cannot rely on tree-sitter.

@BekaValentine
Copy link
Contributor Author

cc @hendrikvanantwerpen @robrix

@robrix
Copy link
Contributor

robrix commented Feb 5, 2024

Echoing some of what you've said above, this is probably a good candidate for issues against tree-sitter and/or tree-sitter-graph, if such don't already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants