Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Metatdata api implementation #992

Closed
hsebouai opened this issue Jun 19, 2023 · 5 comments · Fixed by #1025
Closed

Missing Metatdata api implementation #992

hsebouai opened this issue Jun 19, 2023 · 5 comments · Fixed by #1025

Comments

@hsebouai
Copy link

Right now the library does not expose the Metadata api call like documented in here

@DoubleDPro
Copy link
Contributor

In work

@DoubleDPro
Copy link
Contributor

@jmini Metadata was introduced in Gitlab Version 15.6.0. So we need to change version of Gitlab in integration tests. It required a lot of changes in integration tests and util classes. Can I make PR without updating version of Gitlab in IT and without integration testing of MetadataApi? I checked it in my branch on new version and it work fine! I want to create new issue to update version of Gitlab. What do you think?

@jmini
Copy link
Collaborator

jmini commented Aug 22, 2023

Yes you can create the PR without integration tests.

@jmini
Copy link
Collaborator

jmini commented Aug 22, 2023

About integrations test, there is an open discussion to change the setup: #925

I am fine with a temporary solution where the version would be updated with the current infrastructure.

DoubleDPro added a commit to DoubleDPro/gitlab4j-api that referenced this issue Aug 30, 2023
Added Metadata Api. It requires Gitlab version not less then 15.6 in
integration tests so test was disabled until Gitlab version updating.
@DoubleDPro
Copy link
Contributor

@jmini I made PR. Can you check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants