Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitops-bridge not receiving some annotations from metadata #77

Open
wjbabicz opened this issue Oct 4, 2024 · 0 comments
Open

gitops-bridge not receiving some annotations from metadata #77

wjbabicz opened this issue Oct 4, 2024 · 0 comments

Comments

@wjbabicz
Copy link

wjbabicz commented Oct 4, 2024

Hello! I'm using the gitops-bridge to bootstrap my EKS clusters with Velero and external-dns and I noticed some syncs are failing because the output from the bootstrap-addons doesn't include certain annotations. This is also using a fork of the example apprepo.

For example (external-dns appset):
provider: aws serviceAccount: name: {{.metadata.annotations.external_dns_service_account}} annotations: eks.amazonaws.com/role-arn: '{{.metadata.annotations.external_dns_iam_role_arn}}' domainFilters: {{.metadata.annotations.external_dns_domain_filters}} txtOwnerId: {{.metadata.annotations.aws_cluster_name}} policy: {{default "upsert-only" .metadata.annotations.external_dns_policy}}

domainFliters is passed into the blueprint module from our terraform configuration, but doesn't make it into the metadata output consumed by the bridge, and I receive the following error: Failed to load target state: failed to generate manifest for source 2 of 2: rpc error: code = Unknown desc = helm template . --name-template external-dns --namespace external-dns --kube-version 1.31 --values /tmp/356309be-fd1c-48ea-b0ea-33396de4e076 <api versions removed> --include-crds failed exit status 1: Error: template: external-dns/templates/deployment.yaml:111:29: executing "external-dns/templates/deployment.yaml" at <.Values.domainFilters>: range can't iterate over Use --debug flag to render out invalid YAML

Checking out the blueprint module repo, I wonder if this might be related (in output.tf)? I've also noticed a similar issue with velero where the IAM roles make it in, but the s3 resources are omitted.
{ for k, v in { iam_role_arn = module.external_secrets.iam_role_arn namespace = local.external_secrets_namespace service_account = local.external_secrets_service_account } : "external_secrets_${k}" => v if var.enable_external_secrets },

Please pardon me if I'm creating an issue on the wrong repo, bit of a cross-cutting issue it seems 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant