From 25c2381d6aae4256a9a2d4e72dcd257dc7279412 Mon Sep 17 00:00:00 2001
From: Jonatas <ctfninj4@gmail.com>
Date: Sat, 28 Oct 2023 16:01:02 -0300
Subject: [PATCH] Security Enhancements: Addressing Path Traversal and Command
 Injection

This commit introduces security improvements to the file handling procedures. Specifically, it addresses:

**Path Traversal Vulnerability**: We've implemented a path sanitization method that ensures all file operations are confined within a predefined base directory, thus preventing unauthorized access to files outside of this directory.

**Command Injection**: Replaced the use of os.system() with the safer os.remove() method for file deletion. This change avoids potential command injections and makes the deletion process more secure.
---
 CadVlan/Util/file.py | 60 +++++++++++++++++++++-----------------------
 1 file changed, 29 insertions(+), 31 deletions(-)

diff --git a/CadVlan/Util/file.py b/CadVlan/Util/file.py
index 6565e217..86dcec71 100644
--- a/CadVlan/Util/file.py
+++ b/CadVlan/Util/file.py
@@ -32,6 +32,20 @@ def __str__(self):
 
 
 class File():
+    
+    BASE_PATH = os.path.abspath("./") # Define a base path
+    
+    @staticmethod
+    def _sanitize_path(file_name):
+        '''
+        Create an absolute path and ensure it's within the BASE_PATH.
+        '''
+        abs_path = os.path.abspath(os.path.join(File.BASE_PATH, file_name))
+        
+        if not abs_path.startswith(File.BASE_PATH):
+            raise FileError("Invalid file path")
+
+        return abs_path
 
     @classmethod
     def read(cls, file_name):
@@ -42,16 +56,10 @@ def read(cls, file_name):
         :raise FileError: Failed to reading file
         '''
         try:
-
-            file_name = "./%s" % file_name
-
-            file_acl = open(file_name, "r")
-            content = file_acl.read()
-            file_acl.close()
-
-            return content
-
-        except Exception, e:
+            file_path = cls._sanitize_path(file_name)
+            with open(file_path, "r") as file_acl:
+                return file_acl.read()
+        except Exception as e:
             logger.error(e)
             raise FileError(e)
 
@@ -65,14 +73,10 @@ def write(cls, file_name, content):
         :raise FileError: Failed to writing file
         '''
         try:
-
-            file_name = "./%s" % file_name
-
-            file_acl = open(file_name, "w")
-            file_acl.write(content)
-            file_acl.close()
-
-        except Exception, e:
+            file_path = cls._sanitize_path(file_name)
+            with open(file_path, "w") as file_acl:
+                file_acl.write(content)
+        except Exception as e:
             logger.error(e)
             raise FileError(e)
 
@@ -85,13 +89,10 @@ def create(cls, file_name):
         :raise FileError: Failed to creating file
         '''
         try:
-
-            file_name = "./%s" % file_name
-
-            file_acl = open(file_name, "w")
-            file_acl.close()
-
-        except Exception, e:
+            file_path = cls._sanitize_path(file_name)
+            with open(file_path, "w") as file_acl:
+                pass
+        except Exception as e:
             logger.error(e)
             raise FileError(e)
 
@@ -104,11 +105,8 @@ def remove(cls, file_name):
         :raise FileError: Failed to removing file
         '''
         try:
-
-            file_name = "./%s" % file_name
-
-            erro = os.system("rm %s" % file_name)
-
-        except Exception, e:
+            file_path = cls._sanitize_path(file_name)
+            os.remove(file_path)  # Use os.remove() instead of unsafe os.system()
+        except Exception as e:
             logger.error(e)
             raise FileError(e)