Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guardable Module and Modifier #140

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Guardable Module and Modifier #140

merged 8 commits into from
Oct 9, 2023

Conversation

cristovaoth
Copy link
Contributor

This PR makes the default Module and Modifier leaner:

  • 3kb less in deployed bytecode
  • 2k GAS per modifier call

@auryn-macmillan
Copy link
Member

Looks good! Just need test coverage on GuardableModifier and I think it's good to go.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6454374444

  • 26 of 26 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.0%) to 97.814%
Totals Coverage Status
Change from base Build 6376478791: 3.0%
Covered Lines: 108
Relevant Lines: 109
💛 - Coveralls

auryn-macmillan
auryn-macmillan approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cristovaoth cristovaoth merged commit b899e96 into eip-712-signatures Oct 9, 2023
2 checks passed
@cristovaoth cristovaoth deleted the guardable-module branch October 9, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristovaoth @auryn-macmillan