Remove incorrect documentation and assume pointer is not null in GlobalAlloc::dealloc #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David McNeil <[email protected]>
Signed-off-by: David McNeil <[email protected]>
gnzlbg
reviewed
Dec 11, 2019
| @@ -366,8 +366,6 @@ extern "C" { | |||
| /// | |||
| /// This makes the space available for future allocations. | |||
| /// | |||
| /// If `ptr` is null, no action occurs. | |||
| /// | |||
| /// # Safety | |||
| /// | |||
| /// The behavior is _undefined_ if: | |||
There was a problem hiding this comment.
We probably need to add to these lists that the behavior is undefined if the pointer is null in both cases.
There was a problem hiding this comment.
Addressed in ffdcf7
Signed-off-by: David McNeil <[email protected]>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143